Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Settings upload does not update dose number and requires exclusions/inclusions! #120

Open
js3110 opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@js3110
Copy link
Collaborator

js3110 commented Nov 15, 2024

Description

There are 2 problems:

  • Settings upload does not update dose numbers in Settings Tab of NCA
  • Settings seem to not work when no inclusions/exclusions are in the settings file considered

To reproduce

Upload settings

Expected behaviour

Settings upload should find the dose number (profile) for the settings, and update the dose number widget in settings tab so that these dose numbers are selected in the selectInput
Settings upload should work fine even if no inclusions/exclusions are considered

@js3110 js3110 added the bug Something isn't working label Nov 15, 2024
@js3110 js3110 added this to aNCA Nov 15, 2024
@Gero1999
Copy link
Collaborator

hey @js3110 @m-kolomanski if you don't mind I will take over this one. I feel it could collapse a little bit with what I am currently changing!

@Gero1999 Gero1999 assigned Gero1999 and unassigned m-kolomanski Nov 15, 2024
@js3110
Copy link
Collaborator Author

js3110 commented Nov 19, 2024

@Gero1999 I have also just noticed that settings upload also doesn't work if no exclusions/inclusions were added. Maybe you can include that in this issue? Or should I make a separate one?

@Gero1999 Gero1999 changed the title Bug: Settings upload does not update dose number Bug: Settings upload does not update dose number and requires exclusions/inclusions! Nov 19, 2024
@Gero1999
Copy link
Collaborator

@Gero1999 I have also just noticed that settings upload also doesn't work if no exclusions/inclusions were added. Maybe you can include that in this issue? Or should I make a separate one?

Added here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants