Adding the opposite of open to arrow tips definitions

[Rmano]

Good morning!

If I define a new arrow tip that by default is open, like this (which is still somehow buggy, I can't see exactly why)

%% Jack Tap, see
%% https://github.com/circuitikz/circuitikz/issues/806
\pgfdeclarearrow{name=Jack Tap,
    parameters = {%
    \the\pgfarrowlength,%
    \the\pgfarrowwidth,%
    \ifpgfarrowswap s\fi%
    \ifpgfarrowopen o\fi%
    },
    setup code = {
        \pgfarrowssettipend{.5\pgfarrowlength}
        \pgfarrowssetlineend{-.6\pgfarrowlength}
        \pgfarrowssetvisualbackend{-.6\pgfarrowlength}
        \pgfarrowssetbackend{-.6\pgfarrowlength}
        % hull
        \pgfarrowshullpoint{.5\pgfarrowlength}{0pt}
        \pgfarrowshullpoint{0pt}{\pgfarrowwidth}
        \pgfarrowshullpoint{-.6\pgfarrowlength}{0pt}
        % Saves: Only the length:
        \pgfarrowssavethe\pgfarrowlength
        \pgfarrowssavethe\pgfarrowwidth
    },
    drawing code = {
        \pgfpathmoveto{\pgfqpoint{.5\pgfarrowlength}{0pt}}
        \pgfpathlineto{\pgfqpoint{0pt}{\pgfarrowwidth}}
        \pgfpathlineto{\pgfqpoint{-.5\pgfarrowlength}{0pt}}
        \pgfpathlineto{\pgfqpoint{-.6\pgfarrowlength}{0pt}}
        \ifpgfarrowopen
            \pgfusepathqstroke
        \else
            \pgfpathclose\pgfusepathqfillstroke
        \fi
    },
    defaults = {length = 0.3cm, width=0.15cm,open},
    % cache=false, % breaks everything
}
\tikzset{v/.tip={Jack Tap[swap]}, ^/.tip={Jack Tap}}

then I can't switch to the not-open (closed, filled?) version without knowing the color, i.e., using Jack Barb[fill=black]. Wouldn't it be useful to add a "complementary" switch for open, like, for example:

\pgfkeys{/pgf/arrow keys/filled/.code=\pgfarrowsaddtooptions{\pgfarrowopenfalse}}

Or maybe closed, to convey the not-open thing?

I tried to search for a complementary flag without success, but if it's already there, please tell me ;-)

[muzimuzhi]

It seems the state of open/filled need to be stored in parameters.

 \pgfdeclarearrow{name=Jack Tap,
     parameters = {%
     \the\pgfarrowlength,%
     \the\pgfarrowwidth,
     \ifpgfarrowswap s\fi
+    \ifpgfarrowopen o\fi
    },

Full example (I added open to arrow tip v, v/.tip={Jack Tap[swap, open]})

\documentclass{article}
\usepackage[T1]{fontenc}
\usepackage[siunitx, RPvoltages]{circuitikz}

\pgfdeclarearrow{name=Jack Tap,
    parameters = {%
    \the\pgfarrowlength,%
    \the\pgfarrowwidth,
    \ifpgfarrowswap s\fi
    \ifpgfarrowopen o\fi
    },
    setup code = {
        \pgfarrowssettipend{.5\pgfarrowlength}
        \pgfarrowssetlineend{-.6\pgfarrowlength}
        \pgfarrowssetvisualbackend{-.6\pgfarrowlength}
        \pgfarrowssetbackend{-.6\pgfarrowlength}
        % hull
        \pgfarrowshullpoint{.5\pgfarrowlength}{0pt}
        \pgfarrowshullpoint{0pt}{\pgfarrowwidth}
        \pgfarrowshullpoint{-.6\pgfarrowlength}{0pt}
        % Saves: Only the length:
        \pgfarrowssavethe\pgfarrowlength
        \pgfarrowssavethe\pgfarrowwidth
    },
    drawing code = {
        \pgfpathmoveto{\pgfqpoint{.5\pgfarrowlength}{0pt}}
        \pgfpathlineto{\pgfqpoint{0pt}{\pgfarrowwidth}}
        \pgfpathlineto{\pgfqpoint{-.5\pgfarrowlength}{0pt}}
        \pgfpathlineto{\pgfqpoint{-.6\pgfarrowlength}{0pt}}
        \ifpgfarrowopen
            \pgfusepathqstroke
        \else
            \pgfpathclose\pgfusepathqfillstroke
        \fi
    },
    defaults = {length = 0.3cm, width=0.15cm},
    % cache=false, % breaks everything
}
\tikzset{v/.tip={Jack Tap[swap, open]}, ^/.tip={Jack Tap}}

\newcommand\dx{1.5} \newcommand\dy{1}
\begin{document}


\begin{circuitikz}
    \draw[-v] (0,\dy/3*4) to[short, o-] ++(\dx,0);
    \draw[-Triangle] (0,\dy) node[ocirc]{} -| ++(\dx/3,\dy/3);
    \draw[-Triangle] (0,\dy/3*2) node[ocirc]{} -| ++(\dx/3,-\dy/3);
    \draw[-^] (0,\dy/3) to[short, o-] ++(2*\dx/3,0);
    \draw (0,0.0) to[short, o-] ++(1.75*\dx,0) rectangle ++(0.2,4*\dy/3);
\end{circuitikz}\qquad\qquad
%--- % audio jack with an inserted plug
\begin{circuitikz}
    \draw[-v] (0,\dy/3*4) to[short, o-] ++(\dx,0.2);
    \draw[-Triangle] (0,\dy) node[ocirc]{} -| ++(\dx/3,\dy/3);
    \draw[-Triangle] (0,\dy/3*2) node[ocirc]{} -| ++(\dx/3,-\dy/3);
    \draw[-^] (0,\dy/3) to[short, o-] ++(2*\dx/3,-0.2);
    \draw (0,0.0) to[short, o-] ++(1.75*\dx,0) rectangle ++(0.2,4*\dy/3);
\end{circuitikz}
\end{document}

[Rmano]

Hi, yes, I have seen it - thanks. Still, I need to add the filled trick if I want to have the tip open by default, and then be able to fill it without specify a color... See circuitikz/circuitikz#810 (comment) for example (the code is at https://github.com/circuitikz/circuitikz/pull/810/files ).

The \pgfkeys{/pgf/arrow keys/filled/.code=\pgfarrowsaddtooptions{\pgfarrowopenfalse}} seems to work well...

[muzimuzhi]

Agreed. Somehow /pgf/arrow keys/fill is defined as value required, so currently there's no way to only turn off filling state of an arrow tip.

I'll create a feature request issue from this discussion.