Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue and request to move https://fontinfo.opensuse.org/ to new openSUSE theme #3

Open
lrupp opened this issue Feb 3, 2022 · 9 comments

Comments

@lrupp
Copy link

lrupp commented Feb 3, 2022

The current public page at https://fontinfo.opensuse.org/ is still using the initial openSUSE theme, deployed ~10 years ago.

Meanwhile, there is not only a new theme, but also a security bug in one of the referenced JavaScript files.

So I have two questions:

  1. Can you please check, if the referenced jquery.js is really needed for the current https://fontinfo.opensuse.org/ ? - Or if it can be removed?
  2. Wouldn't it make sense to upgrade the page to the new theme as well, to have it unified across all openSUSE pages?
@pgajdos
Copy link
Owner

pgajdos commented Feb 8, 2022

@lrupp yes, I could consider to spend hackweek on that.

@pgajdos
Copy link
Owner

pgajdos commented Jun 21, 2022

2c52b62 plus a segfault and few failed asserts fixed now.

@pgajdos
Copy link
Owner

pgajdos commented Jun 21, 2022

Now: can someone have a hint for me how to utilize jekyll theme instead of bento one?

@pgajdos
Copy link
Owner

pgajdos commented Jun 21, 2022

@cboltz
Copy link

cboltz commented Jun 21, 2022

From a quick look, I have the impression that you generate the page from C code, so jekyll probably doesn't make too much sense. Also, jekyll is a static site generator, the theme we use is called chameleon ;-)

So - you are probably looking for the chameleon theme ;-)

You can find it on https://github.com/openSUSE/chameleon and some usage examples on https://static.opensuse.org/chameleon-3.0/ https://static.opensuse.org/chameleon-3.0/components.html and https://static.opensuse.org/chameleon-3.0/elements.html

If yo have questions, @hellcp can probably help you.

@hellcp
Copy link

hellcp commented Jun 21, 2022

I was actually considering using jekyll with fontinfo by making a theme that generated yaml files instead of html, so that I could minimize the amount of templating that was done in C and move it onto an actual templating engine. I didn't get very far with that though ;)

@pgajdos
Copy link
Owner

pgajdos commented Jun 22, 2022

Thanks for tips, I will try something and let's see.

@hellcp
Copy link

hellcp commented Jun 22, 2022

Feel free to ask, some stuff we do in the themes may appear a bit cryptic, but it has some purpose more often than not. I can probably also help a bit with general page layout so it flows better, but that may be a bit out of scope :P

@pgajdos
Copy link
Owner

pgajdos commented Jun 30, 2022

I think I have finished work on utilizing chameleon theme. New content will be published soon. jekyll is still not used, I think it will take lot of time I do not have right now. Thanks to @lrupp for patient explaining.

Feel free to ask, some stuff we do in the themes may appear a bit cryptic, but it has some purpose more often than not. I can probably also help a bit with general page layout so it flows better, but that may be a bit out of scope :P

@hellcp, thanks, please look at new fontinfo as soon as it is there and propose changes here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants