Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to detach node #345

Open
take-cheeze opened this issue Jun 10, 2019 · 0 comments
Open

Better way to detach node #345

take-cheeze opened this issue Jun 10, 2019 · 0 comments

Comments

@take-cheeze
Copy link
Contributor

When removing multiple nodes from the graph we need to update GetLiveNodes or check whether node is detached.
It's OK for now since point that needs checking or update is only here.
Though it may need to do either in other places in the future and it's not a good thing to do every time.

  • Update live nodes list after every node mutation
  • Keep the inputs/outputs of node and remove detached in correct timing(May need some modification in ONNX generator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant