-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance regression in EspNet E2E with csj recipie #295
Comments
|
As I chatted locally, this regression was caused in this 3 months or so and #289 is not the culprit. So, let me highjack this issue to handle the perf regression. Copy and paste of how to run the test:
The following command runs the same network by Chainer for reference:
|
It looks like OneHot is the bottleneck, but it might not. I it's just forcing GPU to sync due to AsScalar or something. Maybe returning Scalar type from IntScalarConstantOp and FloatScalarConstantOp and using Scalar as an argument of OneHot would remove the bottleneck. I'm not sure just removing the GPU sync helps, but it would be a good change anyway. |
relates to: #289
The text was updated successfully, but these errors were encountered: