Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign dtype_inference.cc #257

Open
shinh opened this issue May 19, 2019 · 0 comments
Open

Redesign dtype_inference.cc #257

shinh opened this issue May 19, 2019 · 0 comments

Comments

@shinh
Copy link
Member

shinh commented May 19, 2019

Current dtype_inference.cc handles coercion like Mul(x:int32, y:float32) => z:float32. However, the backprop of this op will be Mul(gz:float32, x:int32) => gy:float32 (OK) and Mul(gz:float32, y:float32) => gx:int32 (fail). This issue is exposed in #247 . I think we should probably insert Cast operations automatically instead of allowing coercion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shinh