Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module hierarchy #3

Open
dmopalmer opened this issue Jan 10, 2018 · 0 comments
Open

Module hierarchy #3

dmopalmer opened this issue Jan 10, 2018 · 0 comments

Comments

@dmopalmer
Copy link
Contributor

Currently the setup.py has things like:

               Extension(name="FBLS_cy",
                         sources=["FFA/FBLS_cy.pyx"],
                         include_dirs=[numpy.get_include()]),

and so FBLS_cy, BLS_cext,fold, etc. are part of the global module namespace.

import fold

Would it be better to put everything into the FFA for better namespace, and import them e.g. as:

import FFA.fold   # No risk of confusion with the 'fold' package which is in pypi
# or
import FFA.FFA_cext as FFA    # Easy way to switch between implementations without changing later code

I believe you can do that as:

            Extension(name="FFA.FBLS_cy",

but I haven't tried it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant