add getnetworkinfo RPC #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getnetworkinfo seems to replace getinfo on later versions. Version > 0.18.0 no longer support getinfo()
ankh2054
commented
Oct 30, 2019
petertodd
reviewed
Oct 31, 2019
bitcoin/rpc.py
Outdated
| r['paytxfee'] = int(r['paytxfee'] * COIN) | ||
| return r | ||
| except: | ||
| print("getnetworkinfo replaces getinfo on versions > 0.16.0, please use getnetworkinfo()") |
There was a problem hiding this comment.
This should print to stderr or maybe call depreciationwarning or similar.
There was a problem hiding this comment.
added DepreciationWarning seems to work well. Hope that works, otherwise let me know and I can add more. I'm very new to python so excuse my ignorance on some things.
|
I am currently working on a full update of RPC calls based on v0.19.0.1, which should cover this as well. I am almost done with writing the code. How should I handle conflicts with this PR? |
|
I'd say do whatever is best for your PR. We can fix conflicts later.
…On August 12, 2020 5:41:40 PM EDT, Sachin Meier ***@***.***> wrote:
I am currently working on a full update of RPC calls based on v0.19.0.1, which should cover this as well. I am almost done with writing the code. How should I handle conflicts with this PR?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#217 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getnetworkinfo replaces getinfo on versions > 0.16.0 .
bitcoin/bitcoin#8780