CMerkleBlock class and wire messages #124
Open
+199
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! I've really busy for the rest of this week, but I should get a chance to look at this next week. |
|
Did you try the unit tests? Just tried them and both python2 and python3 unit tests seem to be failing with this change. You can run them with the following command: |
|
I only ran the tests I added separately. Not sure why it would cause other tests to fail as no other code was modified, but I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had this code for a while, figured I'd submit it. I've run it on the network and it has worked, but you'll definitely want to review it.
Also, to use this code, the version in the
msg_versionwould need to be bumped and the relay boolean added.