Incorrect closing of anchor tags when wrapped around a table tag #192

piyush-moengage · 2018-06-05T10:10:04Z

Wrapping a table tag with an a tag is an HTML5 feature which is not supported.

So :

<html><head></head><body>
<a href="http://www.google.com"><table><tbody><tr>hello</tr></tbody></table></a>
</body></html>

Gets converted to:

<html><head></head><body>
<a href="http://www.google.com"></a><table><tbody><tr>hello</tr></tbody></table>
</body></html>

Notice that Premailer closes the anchor tag before the table tag.

The text was updated successfully, but these errors were encountered:

peterbe · 2018-06-05T16:35:57Z

Any reason why you would want to wrap a block element in a inline element.

Pretty sure it's invalid HTML so if that's how lxml is very unlikely that premailer will try to work around this.

elidickinson · 2018-06-05T18:18:28Z

HTML5 allows "block-level links" now, but I've heard it causes headaches for various screenreaders and spiders. And, apparently, LXML's HTML parser

shyamchandranmec · 2018-06-07T12:52:12Z

Any plans to release HTML5 parser for premailer?

peterbe · 2018-06-07T13:38:50Z

@shyamchandranmec What "HTML5 parser"?

shyammoengage · 2018-06-11T09:26:53Z

@peterbe In HTML5 it's valid to wrap block level element inside an inline element.

peterbe · 2018-06-11T12:23:35Z

In HTML5 it's valid to wrap block level element inside an inline element.

wow! I did not know that. Either way, premailer is "only as good" as lxml.

Provide feedback