Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev kmr #30

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Dev kmr #30

merged 2 commits into from
Sep 23, 2024

Conversation

k-rister
Copy link
Contributor

No description provided.

@k-rister k-rister requested a review from atheurer September 20, 2024 19:38
@k-rister k-rister self-assigned this Sep 20, 2024
This was referenced Sep 20, 2024
Closed
Closed
rafaelfolco
rafaelfolco approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - long-term solution is the workshop arch key

@k-rister
Copy link
Contributor Author

lgtm - long-term solution is the workshop arch key

Yep: perftool-incubator/workshop#86

@k-rister k-rister merged commit d1172b4 into master Sep 23, 2024
1 check passed
@k-rister k-rister deleted the dev-kmr branch September 23, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfolco rafaelfolco rafaelfolco approved these changes

@atheurer atheurer Awaiting requested review from atheurer

Assignees

@k-rister k-rister

Labels
None yet
Projects
Crucible Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-rister @rafaelfolco