Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --tty to the rickshaw-run pod command #303

Merged
merged 1 commit into from
Apr 21, 2023
Merged

add --tty to the rickshaw-run pod command #303

merged 1 commit into from
Apr 21, 2023

Conversation

k-rister
Copy link
Contributor

  • this allows a SIGINT generated by typing CTRL-C to be delivered to rickshaw-run

  • if --tty is added to ${container_rs_args[@]} it breaks result summary generation so only do it here

@k-rister
add --tty to the rickshaw-run pod command
f2591af 
- this allows a SIGINT generated by typing CTRL-C to be delivered to
  rickshaw-run

- if --tty is added to ${container_rs_args[@]} it breaks result
  summary generation so only do it here
@k-rister k-rister added the bug Something isn't working label Apr 21, 2023
@k-rister k-rister requested a review from a team April 21, 2023 13:45
@k-rister k-rister self-assigned this Apr 21, 2023
@k-rister k-rister linked an issue Apr 21, 2023 that may be closed by this pull request
Graceful shutdown when a CTRL-C (or similar activity) is entered on the controller #278
Open
@k-rister k-rister merged commit 6aee0a9 into master Apr 21, 2023
@k-rister k-rister deleted the dev-kmr branch April 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfolco rafaelfolco rafaelfolco approved these changes

Assignees

@k-rister k-rister

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graceful shutdown when a CTRL-C (or similar activity) is entered on the controller
2 participants
@k-rister @rafaelfolco