Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support U24 #1441

Closed
5 tasks done
mfeit-internet2 opened this issue Jun 12, 2024 · 6 comments
Closed
5 tasks done

Support U24 #1441

mfeit-internet2 opened this issue Jun 12, 2024 · 6 comments
Assignees

Comments

@mfeit-internet2
Copy link
Member

mfeit-internet2 commented Jun 12, 2024

Title says it all.

TO-DO:

  • Do a build with OWAMP present and make sure that all works
  • Consolidate macros that determine whether or not to build iperf3.
  • Build of pscheduler-tool-s3-benchmark doesn't work right because of missing dependency
  • Convert all use of Python re to use raw strings (r'') to dodge invalid escape sequence warnings
  • Upgrade jq to 1.7 (See Upgrade jq to 1.7 #1445)
@laeti-tia
Copy link
Member

I just tested a build from the issue-1441 branch and see a possible problem with jq. Ubuntu 24 is shipping jq-1.7.1 which gets installed instead of our own 1.6.0 build. And I then get this error:

ERROR:  ImportError: /usr/lib/python3/dist-packages/_pyjq.cpython-312-x86_64-linux-gnu.so: undefined symbol: jv_is_integer_large

Should we force installing our 1.6.0 or should we build a newer 1.7.1 containing this missing function?

@mfeit-internet2 mfeit-internet2 mentioned this issue Jun 18, 2024
8 tasks
@mfeit-internet2
Copy link
Member Author

Neither. The missing function was added as part of a patch to resolve #717 and #785. This will be covered by a jq upgrade in #1445.

@mfeit-internet2
Copy link
Member Author

@laeti-tia If we specify 1.6 as a dependency, will that be installed even if 1.7 is available? I'm thinking we should just stick to 1.6 for the bugfix and save the upgrade for the next feature release.

@laeti-tia
Copy link
Member

I also see these warnings under U24, not sure if it's something we should correct or if it's benign:

Setting up python3-pscheduler (5.1.1~a1.0~20240624164801-1) ...
/usr/lib/python3/dist-packages/pscheduler/mtu.py:13: SyntaxWarning: invalid escape sequence '\s'
  hop_match = re.compile("^\s*[0-9]+\??:")
/usr/lib/python3/dist-packages/pscheduler/ping.py:24: SyntaxWarning: invalid escape sequence '\s'
  "\s+from (.*):"
/usr/lib/python3/dist-packages/pscheduler/sinumber.py:30: SyntaxWarning: invalid escape sequence '\.'
  si_regex = re.compile('^(-?[0-9]+(\.[0-9]+)?)\s*([kmgtpezy][i]?)?$')

and some others on ping.py

@laeti-tia
Copy link
Member

laeti-tia commented Jun 24, 2024

@laeti-tia If we specify 1.6 as a dependency, will that be installed even if 1.7 is available? I'm thinking we should just stick to 1.6 for the bugfix and save the upgrade for the next feature release.

We'll need to add an APT configuration file to make it work, because the version number is lower. That can be done with the following content in /etc/apt/preferences.d/99-perfsonar-jq:

Package: jq libjq1
Pin: release perfsonar-5.1*
Pin-Priority: 510

And use the latest changes pushed to the branch, see 0f55ab6

@mfeit-internet2
Copy link
Member Author

With the completion of #1445, 5.2 will have jq 1.7, so the patch problem goes away and U24 can use the version provided by the distro.

There is now a functioning build on U24, so I'm calling this good.

@github-project-automation github-project-automation bot moved this from In Progress to Done in perfSONAR Jul 2, 2024
mfeit-internet2 added a commit that referenced this issue Jul 22, 2024
* Fix jsonval test to work with JSONSchema 3 and 4

* Clean out unused Debian versions of PostgreSQL #1441

* Remove iperf3 change that shouldn't be there yet.  #1441

* Build iperf3 on u24.  1441

* Enable s3-benchmark for u24+  #1441

* Add iperf3 for u22  #1441

* Build iperf3 on d11; remove conditions in build order.  #1441

* Restore conditional iperf3 build; enable force-build on Debuntu  #1441

* unibuild-order changes:
- Clarifying comments on iperf3 and py-amqp builds.
- Simplifying python-jsonschema condition.

* Forcing jq version 1.6.something to avoid 1.7.1 from U24, pending #1445
Incrementing package release number and adding changelog entries where
needed.

* Make all Python regexps raw strings.  #1441

* Fix escaping in raw regexp strings.  #1441

* Potential TODO for Golan stuff.  #1441

* Bump Debian compat files 9 -> 10.  #1441

---------

Co-authored-by: Lætitia Delvaux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants