Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iperf3 dependencies #1398

Closed
2 tasks done
mfeit-internet2 opened this issue Jan 29, 2024 · 2 comments
Closed
2 tasks done

Update iperf3 dependencies #1398

mfeit-internet2 opened this issue Jan 29, 2024 · 2 comments
Assignees

Comments

@mfeit-internet2
Copy link
Member

mfeit-internet2 commented Jan 29, 2024

Iperf3's dependencies need fixing:

  • It detects OpenSSL 3 if it's present and flops back to 1.1.1 if it's not. Adjust build/install dependencies for that.
  • Add pthreads, which we're probably getting by coincidence. (No need. Now part of GCC.)
@laeti-tia
Copy link
Member

Use SSL3 on Debian (RH picks it up automagically). #1398 094f3df

Debian does this too, this change is not needed.

@mfeit-internet2
Copy link
Member Author

Dropping the issue-1398 branch without merging it, then.

Explanation from Slack for posterity:

Lætitia A Delvaux 6:25 AM
No we don’t need this change, libssl3-dev is not a package that exists in Debian (12 or else), but libssl-dev in Debian 12 is already openssl3: https://packages.debian.org/bookworm/libssl-dev
That’s even why I had named the iperf3 Debian 12 build iperf3-ssl3 (edited)

packages.debian.orgpackages.debian.org
Debian -- Details of package libssl-dev in bookworm
Secure Sockets Layer toolkit - development files

Lætitia A Delvaux 6:33 AM
But what I missed was changing the dependency in pscheduler-tool-iperf3 to the iperf3-ssl3 new binary. I’ve just corrected that in 5d5c499

Lætitia A Delvaux 6:38 AM
I know this is a bit tricky, but that’s how we handle the differences in OS. We build and distribute both iperf3 (built on Debian 10, with openssl) and now also iperf3-ssl (built on Debian 12, with openssl3) but they have different names so not to conflict in the repository. pscheduler-tool-iperf3 was missing this change and I hadn’t spotted it. I’ll launch a new pScheduler build to have it right, it will take a bit.
6:38
For python-jsontemplate I’ll let you see what’s best Mark. We can also patch as Daniel suggested from Stack Overflow.

@github-project-automation github-project-automation bot moved this from In Progress to Done in perfSONAR Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants