Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Finder Interface #189

Open
beetlebugorg opened this issue Nov 25, 2019 · 0 comments
Open

Improve Finder Interface #189

beetlebugorg opened this issue Nov 25, 2019 · 0 comments

Comments

@beetlebugorg
Copy link
Contributor

After using the finder implementation ($(external-query ..) and Finder class) for a bit we've determined there are a few tweaks that should be made to improve it.

  • Populate finder fields and use them instead of the filter map.
  • Throw an error if a field is provided that cannot be filtered on. The primary goal is to require the user to explicitly query using findAll when they want to find something that cannot be filtered using the filters provided by the various cloud APIs.
  • Update @for, @log, and @print directives to use streams
  • Update the interface to allow for streaming results.
public abstract class Finder<R extends Resource> {

    Scope scope;

    public abstract Stream<R> findAll();

    public abstract Stream<R> find();

}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant