Add ibc source badge to asset icons #1864
Labels
ui
Related to user interface or ux design
Comments
|
The rendering should be a circle 1/2 of the radius of the main icon (so 1/4 the area) and placed in the lower right quadrant, aligned with the edge of the icons: 
|
|
xref prax-wallet/registry#97 for proposed policy -- this shouldn't apply to all assets, just bridged ones |
2 tasks
cronokirby
pushed a commit
to penumbra-zone/penumbra
that referenced
this issue
Oct 23, 2024
## Describe your changes Web apps are currently unable to visually distinguish certain IBC assets that represent rehypothecated tokens. Aka, Bitcoin from Osmosis or Nomic. Both of their metadata possess images of the plain Bitcoin logo. This proto change proposes to add a new field: `badges`. It gives entities like the [prax registry](https://github.com/prax-wallet/registry) the ability to add source chain icons to the metadata of assets. Frontends can then display these badges [on top of](penumbra-zone/web#1864 (comment)) the asset icon. ## Issue ticket number and link penumbra-zone/web#1864 prax-wallet/registry#97 ## Checklist before requesting a review - [x] (not relevant) I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only a protobuf schema update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, minifront indiscriminately displays the asset icon provided by the prax asset registry in the
ValueViewComponent. Example:The challenge is that this can mislead users. For example, Penumbra can connect to multiple Cosmos chains that each may have a Bitcoin variation using the same Bitcoin icon. For users, it would be impossible to distinguish them in the UI. There should be a way for frontends to be able to label assets depending on the channel source, so it's clear to users where it is coming from.
Task: Add a
badgesfield to the Metadata proto that allows the registry to add the ibc chain icon to the asset's badge list.Steps:
penumbra-zone/penumbrato include a newbadgesfield (type: ~Vec<Image>)ValueViewComponentto show badge on top of icon.The text was updated successfully, but these errors were encountered: