Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove debugging lines (left in during #49) #52

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: remove debugging lines (left in during #49) #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poseidon-parameters/src/matrix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use anyhow::{anyhow, Result};
use ark_ff::{vec, vec::Vec, PrimeField};
use num_integer::Roots;

use crate::matrix_ops::{mat_mul, MatrixOperations, Polynomial, SquareMatrixOperations};
use crate::matrix_ops::{mat_mul, MatrixOperations, SquareMatrixOperations};

/// Represents a matrix over `PrimeField` elements.
///
Expand Down
6 changes: 5 additions & 1 deletion poseidon-permutation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,8 @@
# 0.4.0

* Use `v1` APIs from parameter crates.
* Use `poseidon-permutation` R1CS implementation.
* Use `poseidon-permutation` R1CS implementation.

# 0.5.0

* Fix: Removing unnecessary debug output.
2 changes: 1 addition & 1 deletion poseidon-permutation/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "poseidon-permutation"
version = "0.4.0"
version = "0.5.0"
edition = "2018"
authors = ["Penumbra <[email protected]>", "redshiftzero <[email protected]>"]
description = "An instantiation of the Poseidon permutation"
Expand Down
4 changes: 1 addition & 3 deletions poseidon-permutation/src/r1cs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#![allow(non_snake_case)]
use ark_ff::PrimeField;
use ark_std::{dbg, vec::Vec};
use ark_std::vec::Vec;

use ark_r1cs_std::{fields::fp::FpVar, prelude::*};
use ark_relations::r1cs::ConstraintSystemRef;
Expand Down Expand Up @@ -63,9 +63,7 @@ where
self.state_words[i] += round_constants[round_constants_counter];
round_constants_counter += 1;
}
dbg!("bout to SubWord: ", self.cs.num_constraints());
self.full_sub_words();
dbg!("after x^a: ", self.cs.num_constraints());
self.mix_layer_mds();
}

Expand Down
4 changes: 4 additions & 0 deletions poseidon377/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@
# 0.5.0

* Use `poseidon-permutation` R1CS implementation.

# 0.6.0

* Use `poseidon-permutation` version 0.5.0 to avoid spurious debug output.
4 changes: 2 additions & 2 deletions poseidon377/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "poseidon377"
version = "0.5.0"
version = "0.6.0"
edition = "2018"
authors = ["Penumbra <[email protected]>", "redshiftzero <[email protected]>"]
description = "An instantiation of the Poseidon hash for use with decaf377."
Expand All @@ -17,7 +17,7 @@ decaf377 = { version="0.4", default-features = false, features = ["r1cs"] }
num-bigint = { version = "0.4.3", default-features = false }
once_cell = { version = "1.8", default-features = false }
poseidon-parameters = { version="0.4", path = "../poseidon-parameters", default-features = false }
poseidon-permutation = { version="0.4", path = "../poseidon-permutation", default-features = false }
poseidon-permutation = { version="0.5", path = "../poseidon-permutation", default-features = false }

# Dependencies added for ark-sponge vendoring
ark-ec = { version = "0.4", default_features = false, optional=true }
Expand Down