From 6b4d634df94f19309e05174f3c2196284df38fb6 Mon Sep 17 00:00:00 2001 From: Rohan Gupta Date: Sun, 10 Jul 2022 00:17:13 -0700 Subject: [PATCH 1/2] allow integrationTests to be string --- cdk/kraken/src/labs-application.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cdk/kraken/src/labs-application.ts b/cdk/kraken/src/labs-application.ts index 5cc49a0c..3a02c215 100644 --- a/cdk/kraken/src/labs-application.ts +++ b/cdk/kraken/src/labs-application.ts @@ -28,10 +28,10 @@ export interface LabsApplicationStackProps { frontendPath?: string; /** - * If true, run integration tests using docker-compose. + * If evaluates to true, run integration tests using docker-compose. * @default false */ - integrationTests?: boolean; + integrationTests?: boolean | string; /** * Base name of the docker images to publish. From 2f73812c6c857bb9b9f9dbb3ae98382a08bdb9ee Mon Sep 17 00:00:00 2001 From: Rohan Gupta Date: Sun, 10 Jul 2022 00:22:36 -0700 Subject: [PATCH 2/2] modify downstream flag --- cdk/kraken/src/docker.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cdk/kraken/src/docker.ts b/cdk/kraken/src/docker.ts index 0fc0bc88..7a6d4dee 100644 --- a/cdk/kraken/src/docker.ts +++ b/cdk/kraken/src/docker.ts @@ -53,11 +53,11 @@ export interface DockerPublishJobProps { cache?: boolean; /** - * If enabled, do not publish docker image to Docker Hub. + * If evaluates to true, do not publish docker image to Docker Hub. * Instead upload as an artifact. * @default false */ - noPublish?: boolean; + noPublish?: boolean | string; } /**