Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet_threading: broke line drawing error #95

Closed
cybertosher opened this issue May 15, 2023 · 23 comments
Closed

bullet_threading: broke line drawing error #95

cybertosher opened this issue May 15, 2023 · 23 comments

Comments

@cybertosher
Copy link

After the latest update there are small vertical lines that do not line up properly on Windows 10 machine. This was not the case on Friday, so I assume it is the latest commit to fix items on mobile platforms that did it.

Screenshot 2023-05-15 091018

@UNICKCHENG
Copy link
Collaborator

UNICKCHENG commented May 15, 2023

@cybertosher I'm sorry for causing you trouble. The main reason is that Logseq was recently updated to version 0.9.6, which caused compatibility issue(#92). This issue seems to have been fixed before(#93), but it still appears in your screenshot. Could you please try the following steps to check again?

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.

@UNICKCHENG
Copy link
Collaborator

If you find this issue still exists, you can try adding the following code to logseq/custom.css and adjusting the value of "left" to fix it.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

image

@cybertosher
Copy link
Author

cybertosher commented May 16, 2023

Greeting! None of these worked for me. I was not using the logseq-dev-theme, I was using Bonofix before this issue started. What I tried was this:

  1. I downloaded the latest dev theme (1.26.17) and verified that the custom.css file was empty. No change.
  2. I selected the dev theme as my active theme, no change.
  3. I added the custom css code above and no change
  4. I deleted Bonofix and ensured that dev theme was the only theme installed, no change
  5. Restarted logseq several times, no change.

So unfortunately I still have the issue with threading not working, but the additional distraction of a theme I don't like as much. 😄 Any ideas when or if this will be fixed, or something else I can try?

Thanks for all of your efforts.

@MaxenceG2M
Copy link

MaxenceG2M commented May 16, 2023

Hi!

I have the same problem, but the @UNICKCHENG fix works for me with a really huge value (e.g. -500).

There is a screenshot with a value of -200:
image

The last really deep bullets bring back the problem.

HtH

By the way, thank you for your work on this great plugin, one of the most essential for me :)

@cybertosher
Copy link
Author

cybertosher commented May 16, 2023

I tried the custom.css code with -250px as the offset, as @MaxenceG2M suggested, and it cleans up the issue for the bullet levels I use. I'm OK with weird artifacts that only happen sometimes.

And I agree, thanks for all of your work @UNICKCHENG on this plugin, it is definitely my favorite.

@Vitor12xx
Copy link

Vitor12xx commented May 18, 2023

I was able to use @UNICKCHENG fix to align the rogue vertical line with -16px as the offset.

Thanks for the fix!

@cybertosher
Copy link
Author

cybertosher commented May 19, 2023

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

@UNICKCHENG
Copy link
Collaborator

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

A more universal solution than this one cannot be found at present, but I believe that this issue will eventually be resolved in the future.

@schmy
Copy link

schmy commented May 21, 2023

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child?
image

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

@ericz15
Copy link

ericz15 commented May 21, 2023

Hi, I encountered the same issue and wanted to share my custom.css file:

@import url("https://cdn.jsdelivr.net/gh/sokirill/logseq-panic-theme@main/custom.css");

:root {
    --ct-code-font-family: Maple Mono, Fira Code, Monaco, Menlo, Consolas, 'COURIER NEW', "等距更纱黑体 SC", monospace;
    --ls-font-family: Verdana, 'fira sans', 'segoe UI Emoji', 'sarasa ui sc', sans-serif;
}

#root>div,
html,
body {
    font-family: var(--ls-font-family);
}

:not(pre)>code,
.CodeMirror {
    font-family: var(--ct-code-font-family);
}

I've tried the solution mentioned earlier with left: -21px;, but unfortunately, the issue still persists.

image

Thank you for your attention to this matter.

Update: I tried left: -15px;, and it works for me.

@ginko-ai
Copy link

I have similar issue, (luv the plug-in btw)
Screenshot 2023-05-21 084244

@UNICKCHENG
Copy link
Collaborator

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child? image

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

@schmy Try modifying the value of "right" like right: 50px ?

.ls-block > div > div.items-center::before {
    right: 10px !important;
}

image

@UNICKCHENG
Copy link
Collaborator

UNICKCHENG commented May 22, 2023

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.

@cybertosher
Copy link
Author

cybertosher commented May 22, 2023

Just an update: for some reason my logseq at work does not automatically update. I manually updated to logseq version 0.9.6, applied the -21px offset in custom.css and now everything draws correctly.

@UNICKCHENG UNICKCHENG changed the title Latest update broke line drawing bullet_threading: broke line drawing error May 29, 2023
@UNICKCHENG UNICKCHENG pinned this issue May 29, 2023
@whZhang1
Copy link

whZhang1 commented Jun 3, 2023

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

I have the same quesiton and how to solve this?

@UNICKCHENG
Copy link
Collaborator

UNICKCHENG commented Jun 3, 2023

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.

@Zhangwuhao here ? If there are still errors, could you provide screenshots and configuration information?

@Strubbl
Copy link

Strubbl commented Jun 16, 2023

I have a similar issue:

grafik

I have no content in logseq/custom.css. This issue was fixed for me, when i installed the plugin Bullet threading. So i can reproduce the issue by deactivating that plugin.

@reprintsev
Copy link

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

@DreamWaterFound
Copy link

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

@DreamWaterFound
Copy link

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.
Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.
I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

Sorry, I need to apologize for my arbitrary conclusion. The method above eliminates the display of vertical lines, which exposes an issue on pages with title text. Below is the erroneous display with vertical lines:

Screenshot from 2023-06-26 15-51-04

Whereas the following is the result with the vertical lines removed:

Screenshot from 2023-06-26 15-50-53

So in the end, I still need to adjust the left offset. At the same time, I noticed an issue with the curve and bullet points not aligning closely. Thanks to @UNICKCHENG, I referred to this reply and used the following code in logseq/custom.css to achieve a nearly perfect effect:

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13px;
}
.ls-block > div > div.items-center::before {
    right: 10px !important;
}

Screenshot from 2023-06-26 15-56-01

I hope my experience is helpful to someone.


OS: ubuntu 20.04
Logseq: 0.9.9
logseq-dev-theme: 1.26.17

@UdeRecife
Copy link

UdeRecife commented Jul 23, 2023

EDIT:
I managed to solve the issue by tweaking the value even further.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13.8px;
}

@cybertosher
Copy link
Author

cybertosher commented Mar 17, 2024

Broken again. I have logseq 0.10.7 and the latest dev theme, and once again there is a little broken line. No configuration in custom.css. Is the best way to fix this one again to add the custom CSS, or is there an error with the theme maybe that fixes it? I do not have this issue on Windows 10, only MacOS. This is kind of like Whack-A-Mole

OK, so today I learned (I am slow like this) that the dev theme has bullet threading built in, and that I need to use the dev-theme without bullet threading along with the bullet threading plugin. When I do that, I do not have the little extra bit. So the theme is broken, not the plugin. Closing as my bad.

@cybertosher
Copy link
Author

The plugin seems to be working fine, my issue is with the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests