Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QA Tools / Linters #67

Open
20 of 25 tasks
Potherca opened this issue Jan 2, 2022 · 10 comments
Open
20 of 25 tasks

Add QA Tools / Linters #67

Potherca opened this issue Jan 2, 2022 · 10 comments
Assignees
Labels
Type: QA Issues regarding the quality of the code and application

Comments

@Potherca
Copy link
Member

Potherca commented Jan 2, 2022

We want to add CI/CD tools to all PDS Interop PHP repositories that are dependencies for this repository.

This ticket serves as full list of all the steps that need to be taken.
For all repositories the steps are more or less the same:

  • Create a .github/workflows directory
  • Create a YAML workflow file to lint for PHP syntax errors
  • Create a YAML workflow file to check for PHP version compatibility (PHP Compat)
  • Create a YAML workflow file to check for style violations (PHP CodeSniffer)
  • Create a YAML workflow file to do security checks
  • Create a YAML workflow file to run PHPUnit tests (similar to tests.yml)

This means our worklist is:

  • solid-nextcloud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests see Workflow to run PHPUnit tests #81
  • php-solid-auth

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • php-solid-crud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • flysystem-nextcloud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • flysystem-rdf

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests

If so desired, this list can be broken out into separate tickets in each repo.

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

Since the security check only validates dependancies, we are only adding it to the solid-nextcloud repo:

#79

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

Above PRs are merged.

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

Adding PHP version sniff for solid-nextcloud:
#80

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

Above PR is merged.

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

PHPunit for flysystem/nextcloud: pdsinterop/flysystem-nextcloud#9

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

PHPUnit for php-solid-crud: pdsinterop/php-solid-crud#20

@ylebre
Copy link
Member

ylebre commented Aug 26, 2022

PHPunit for php-solid-auth: pdsinterop/php-solid-auth#24

@Potherca Potherca added this to the v0.6.0 milestone Sep 24, 2022
@Potherca Potherca modified the milestones: v0.6.0, v0.7.2 Oct 19, 2022
@Potherca Potherca modified the milestones: v0.7.2, v0.7.3 Jan 23, 2023
@Potherca
Copy link
Member Author

PHP Code standard added in 3aa3097 and b801021

@Potherca Potherca removed this from the v0.7.3 milestone Jan 20, 2024
@Potherca Potherca added the Type: QA Issues regarding the quality of the code and application label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: QA Issues regarding the quality of the code and application
Projects
None yet
Development

No branches or pull requests

2 participants