Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor directory to AppStore build/release #65

Open
Potherca opened this issue Jan 2, 2022 · 1 comment
Open

Add vendor directory to AppStore build/release #65

Potherca opened this issue Jan 2, 2022 · 1 comment
Labels
Type: QA Issues regarding the quality of the code and application

Comments

@Potherca
Copy link
Member

Potherca commented Jan 2, 2022

Several users that install the Solid-Nextcloud app throuch the NC App Store run into issues caused by the vendor directory not being present. As users should not have to run composer themselves, the vendor directory needs to be part of the packaged release.

Looking at how other packages do this (for instance user_oidc and mail) the most straightforward way of doing this seems to be a combination of using GitHub Actions and krankerl.

In order to have this setup correctly, the package release needs to be automated (see #64), so this can be added as part of the automation.

@Potherca
Copy link
Member Author

The latests release(s) have been verified to have the vendor directory (see main...publish).

Leaving this issue open until #64 has been resolved.

@Potherca Potherca modified the milestones: v0.7.2, v0.7.3 Jan 23, 2023
@Potherca Potherca linked a pull request Jan 25, 2023 that will close this issue
@Potherca Potherca removed this from the v0.7.3 milestone Jan 20, 2024
@Potherca Potherca added the Type: QA Issues regarding the quality of the code and application label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: QA Issues regarding the quality of the code and application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant