fix issue #6 : Create CommentsOverlay component #9
Conversation
ui/Comments/BackButton.tsx
Outdated
| const onBackHandler = () => { | ||
| props.onBack(); | ||
| }; | ||
|
|
||
| return ( | ||
| <TouchableOpacity onPress={onBackHandler} activeOpacity={0.5}> |
There was a problem hiding this comment.
Directly pass props.onBack into TouchableOpacity - no need to create a separate onBackHandler function.
There was a problem hiding this comment.
I thought it would increase readability and hence created separate functions for many one liner functions also. Should I remove them all or is this specific?
There was a problem hiding this comment.
A separate function increases readability if it represents a separate action. In this case, both onBackHandler and props.onBack mean the same thing - a function to be called for going back. Then a separate function is not necessary.
ui/Comments/CommentBlock.tsx
Outdated
| }; | ||
|
|
||
| const CommentBox = (props: Props) => { | ||
| let inpRef: React.RefObject<TextInput> = createRef(); |
There was a problem hiding this comment.
You probably want to use a useRef here, instead of createRef. Read this SO answer.
ui/Comments/CommentBlock.tsx
Outdated
| isVisible={true} | ||
| fullScreen={true} |
There was a problem hiding this comment.
tip: instead of isVisible={true}, you can simply write isVisible - same for fullScreen. Just syntactic sugar.
ui/Comments/index.tsx
Outdated
| type Props = { | ||
| isVisible: boolean; | ||
| onBack: (arg0?: Function) => void; | ||
| comments: Array<IComment>; | ||
| }; | ||
|
|
||
| const CommentBox = (props: Props) => { | ||
| let [isVisible, setIsVisible] = useState(props.isVisible); | ||
|
|
||
| const BackHandler = () => { | ||
| props.onBack(setIsVisible); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I don't get why props.onBack is defined like that - why do you need to pass setIsVisible into props.onBack?
There was a problem hiding this comment.
I was thinking that from screen one would may instead of re-rendering may want to just make comment overlay off by using the setIsVisible but later I realized to make it visible again it has to be re-rendered, and forget to remove it. Will remove it.
devanshusingla
force-pushed
the
master
branch
2 times, most recently
from
4d6decc to
a719e34
Compare
|
Implemented all suggested changes |
|
Fixed with #19. |
Created a comments overlay container. Currently contains an example, after approval will be removed. Currently, it displays max 3 hidden replies which can be changed from CommentList container. onReply function in ReplyBox component logs to console which can be integrated with backend using parent comment information. Resolves #6