Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A PHPDoc type for the $payment argument of the \Paymill\Models\Response\Client::setPayment() method is wrong #140

Open
dmitrii-fediuk opened this issue Feb 11, 2017 · 0 comments
Open

A PHPDoc type for the $payment argument of the \Paymill\Models\Response\Client::setPayment() method is wrong #140

dmitrii-fediuk opened this issue Feb 11, 2017 · 0 comments

Comments

@dmitrii-fediuk
Copy link 

@param \Paymill\Models\Response\Payment $payment

https://github.com/paymill/paymill-php/blob/v4.4.1/lib/Paymill/Models/Response/Client.php#L90

It is wrong, because the method can accept an array (a list of payments) as a $payment argument value.

Related to #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitrii-fediuk