Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for redirect action path to take account of Discourse sub-directory base URL #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sindbach
Copy link

A patch for authorize path to take account of Discourse deployments with subdirectory base URL i.e. www.discourse.com/foo/bar.

Currently it will try to go to URL only on the top level domain i.e. www.discourse.com/authorize?supplier_id=1 where it should have included the subdirectories. i.e. www.discourse.com/foo/bar/authorize?supplier_id=1

@angusmcleod
Copy link
Member

@sindbach Sure thing! Looks like we're getting a qunit failure on this. Do you want to have a go at addressing it? If not I'll take a look in the next few days.

@sindbach
Copy link
Author

I'll try to take a look when I have the chance early next week.
I worked around this bug for our subscription authorisation, so no blocked on this .

Thanks Angus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants