-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items get loaded into memory, needs improving. #30
Comments
I guess this is due to the sorting capability which double the source and sorted data ? |
By the sounds of it it sounds like it might be more than just the double the source.. |
Any updates on this? |
To do a simple test : in DataTableWithDataSourceViewController.swift :
Since sort is slow with huge data set, a spinner could be useful also, if sorting time > 0.2s for example But I also think using 10000 entries is not really practical.... as of right now you have to scroll to the end, page by page. |
Or we could supply the datasource on the fly, but this does mean having to calculate the row heights somehow too.. I imagine this would provide a choppy experience. |
Loading 10000 items isn't practical. There'll be memory issues too.. |
Why calculate the row height? Aren't they constants? |
Custom heights can be returned. |
If anyone has any suggestions I'd love to hear them. |
Basically, looking at how the control is laid out, all the data has to be loaded into
currentRowViewModels
.So while the delegate has a good api that would allow it to provide data sequentially (e.g. from remote api or sqlite db), in practice all the data is loaded into memory in one go.
So if you have just a measly 10K rows over 5 columns, performance is very poor because just to load the data the control does the foreach over that data...
Look at UITableViewDataSource for ideas on improving this.
The text was updated successfully, but these errors were encountered: