Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtp::binary cause lnk1169 on windows #1292

Open
vipcxj opened this issue Nov 21, 2024 · 2 comments
Open

rtp::binary cause lnk1169 on windows #1292

vipcxj opened this issue Nov 21, 2024 · 2 comments

Comments

@vipcxj
Copy link

vipcxj commented Nov 21, 2024

detail see here

It seems that rtp::binary declared in a __declspec(dllimport) class causing we can not declare another std::vector<std::byte> in our application.

I know the c++ api compatibility is very poor, especially with the c++ api that uses stl. what I didn't anticipate was the conflicts that arise even when compiling libdatachannel with the source code~.

@paullouisageneau
Copy link
Owner

rtc::binary is not declared in a __declspec(dllimport) class, it is just a type declared at namespace top-level. No import should be involved.

@vipcxj
Copy link
Author

vipcxj commented Nov 25, 2024

I know, but the reality is that defining a vector<byte> directly myself causes the lnk1169 error, and including "rtc/common.hpp" directly still gives the same error, but including "rtc/track.hpp" or including "rtc/rtc.hpp" the error disappears. So I deduced that it had something to do with __declspec(dllimport).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants