Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending h264 message causes assertion in std vector #1125

Closed
Dakror opened this issue Mar 1, 2024 · 2 comments · Fixed by #1128
Closed

Sending h264 message causes assertion in std vector #1125

Dakror opened this issue Mar 1, 2024 · 2 comments · Fixed by #1128

Comments

@Dakror
Copy link

Dakror commented Mar 1, 2024

In line https://github.com/paullouisageneau/libdatachannel/blame/437a758ae89e5342940c139b8a647bf1bb1c0ee5/src/message.cpp#L34 i get a "Expression: cannot seek vector iterator after end"
@paullouisageneau
Copy link
Owner

This is a zealous check but it's right, I'll push a fix, thank you for reporting.

@paullouisageneau paullouisageneau mentioned this issue Mar 8, 2024
Merged
@paullouisageneau paullouisageneau linked a pull request Mar 8, 2024 that will close this issue
Fix iterator past end of vector #1128
Merged
@Dakror
Copy link
Author

Dakror commented Mar 8, 2024

Awesome, thanks for the rapid fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix iterator past end of vector paullouisageneau/libdatachannel
2 participants
@paullouisageneau @Dakror