From 4bfb6cc26c171d1e42386971ae260012d274092a Mon Sep 17 00:00:00 2001 From: Paul-Louis Ageneau Date: Thu, 24 Oct 2024 11:33:23 +0200 Subject: [PATCH] Prevent installing static deps when building shared library --- CMakeLists.txt | 40 ++++++++++++++++++++++++---------------- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b4bf3503e..cbce1c18b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -270,8 +270,11 @@ endif() target_compile_definitions(datachannel-static PRIVATE RTC_EXPORTS) target_compile_definitions(datachannel-static PUBLIC RTC_STATIC) -if(NOT BUILD_SHARED_DEPS_LIBS) +if(BUILD_SHARED_LIBS AND NOT BUILD_SHARED_DEPS_LIBS) set(BUILD_SHARED_LIBS OFF) + set(INSTALL_DEPS_LIBS OFF) +else() + set(INSTALL_DEPS_LIBS ON) endif() set(CMAKE_THREAD_PREFER_PTHREAD TRUE) @@ -304,19 +307,20 @@ else() endif() add_library(Usrsctp::Usrsctp ALIAS usrsctp) - # usrsctp lacks an export set - install(TARGETS usrsctp EXPORT UsrsctpTargets) - install(EXPORT UsrsctpTargets - FILE UsrsctpTargets.cmake - NAMESPACE Usrsctp:: - DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/usrsctp - EXCLUDE_FROM_ALL) - - # Fix directories - set_target_properties(usrsctp PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "") - target_include_directories(usrsctp INTERFACE - $ - $) + if(INSTALL_DEPS_LIBS) + # usrsctp lacks an export set + install(TARGETS usrsctp EXPORT UsrsctpTargets) + install(EXPORT UsrsctpTargets + FILE UsrsctpTargets.cmake + NAMESPACE Usrsctp:: + DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/usrsctp + EXCLUDE_FROM_ALL) + # Fix directories + set_target_properties(usrsctp PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "") + target_include_directories(usrsctp INTERFACE + $ + $) + endif() endif() target_include_directories(datachannel PUBLIC @@ -376,7 +380,9 @@ else() else() if(NOT TARGET srtp2) add_subdirectory(deps/libsrtp EXCLUDE_FROM_ALL) - install(TARGETS srtp2) + if(INSTALL_DEPS_LIBS) + install(TARGETS srtp2) + endif() endif() target_compile_definitions(datachannel PRIVATE RTC_SYSTEM_SRTP=0) target_compile_definitions(datachannel-static PRIVATE RTC_SYSTEM_SRTP=0) @@ -454,7 +460,9 @@ else() target_link_libraries(datachannel-static PRIVATE LibJuice::LibJuice) else() add_subdirectory(deps/libjuice EXCLUDE_FROM_ALL) - install(TARGETS juice) + if(INSTALL_DEPS_LIBS) + install(TARGETS juice) + endif() target_compile_definitions(datachannel PRIVATE RTC_SYSTEM_JUICE=0) target_compile_definitions(datachannel-static PRIVATE RTC_SYSTEM_JUICE=0) target_link_libraries(datachannel PRIVATE LibJuice::LibJuice)