Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jshint and prettier conflicts #165

Open
ccorda opened this issue Jan 17, 2023 · 1 comment
Open

jshint and prettier conflicts #165

ccorda opened this issue Jan 17, 2023 · 1 comment
Assignees

Comments

@ccorda
Copy link
Contributor

ccorda commented Jan 17, 2023

had an issue today where the prettier ternary formatting like so:

var nextFontSizeIndex = !!currentFontSize
      ? fontSizes.indexOf(currentFontSize) - 1
      : 1;

was causing jshint to error.

Solve ended up being to add this to .jshintrc: "laxbreak": true.

But I wonder if we should move to eslint, since that's what we use in all our react projects.

@ccorda
Copy link
Contributor Author

ccorda commented Jan 23, 2023

Also had an issue where trying to use a rather trivial import lead to all sorts of workarounds and issues that wouldn't have shouldn't have happened if we had basic browser bundling: https://github.com/szymansd/utm-params

@ccorda ccorda self-assigned this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant