Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apple.php #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ibimsdeandy
Copy link

@ibimsdeandy ibimsdeandy commented Jul 18, 2023

The method is declared as public in GenericProvider and any other provider and throws an error if it is protected. If we use this plugin together with bigfork/silverstripe-oauth it works only if the method is public.

set getDefaultScopes to public
@magicsunday
Copy link

getDefaultScopes() is declared as "protected" in league/oauth2-client/src/Provider/AbstractProvider.php, You should not override methode visibility. Maybe you should open an issue in "league/oauth2-client", so they could fix this mismatch.

@patrickbussmann
Copy link
Owner

@ibimsdeandy thank you for your work but tests failing. Please check and then I'll merge. 👍

@patrickbussmann patrickbussmann force-pushed the main branch 14 times, most recently from 6e9831d to 6b38a21 Compare May 17, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants