Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create globally scoped Vault client #56

Closed
patoarvizu opened this issue Jun 20, 2020 · 1 comment
Closed

Create globally scoped Vault client #56

patoarvizu opened this issue Jun 20, 2020 · 1 comment
Assignees

Comments

@patoarvizu
Copy link
Owner

Currently, the operator creates a new Vault client on every reconcile loop. Instead, a global client instance should be created at the beginning of the lifecycle of the operator, and reuse on every reconcile action.

Note that because the lifetime of the operator is likely to be longer than the TTL of any token the client gets, the operator should handle token refresh (or reauthentication if refresh is not possible).

Ideally, the solution for this should keep #55 in mind, to consider the possibility of needing to maintain global clients for multiple endpoints.

@patoarvizu patoarvizu self-assigned this Jun 20, 2020
@patoarvizu
Copy link
Owner Author

Done in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant