Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify deep copy #68

Closed
wants to merge 2 commits into from
Closed

Conversation

BruceWayneLinxu
Copy link

@BruceWayneLinxu BruceWayneLinxu commented Jan 12, 2018

I would like to make it deep copy, and the pointer b.a should not be deleted.

@patmorin
Copy link
Owner

patmorin commented Feb 2, 2018

I agree that this makes much more sense from a software engineering perspective. But, the book was originally written in Java and I want to stick with the convention that array assignment is just a constant-time pointer change. In fact, the only reason for the array class in the C++ version is so that an array remembers its length.

@patmorin patmorin closed this Feb 2, 2018
@tekinozbek
Copy link
Contributor

I think you can close #65 too then; it's the associated issue for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants