Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean-up: prompt template string elements repeated across code locations #31

Open
dxtrous opened this issue Mar 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request priority:low Triaged: low priority issue

Comments

@dxtrous
Copy link
Member

dxtrous commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
The following lines of code:
https://github.com/pathwaycom/pathway/blob/main/python/pathway/xpacks/llm/prompts.py#L121
https://github.com/pathwaycom/pathway/blob/main/python/pathway/xpacks/llm/question_answering.py#L15
https://github.com/pathwaycom/pathway/blob/main/python/pathway/xpacks/llm/prompts.py#L35
define string constants representing no-answer-found in separate ways. I am wondering if there is a purpose in having a default argument value which is overridden by its primary wrapper.

Describe the solution you'd like
This could merit clean-up.

Describe alternatives you've considered
Leave as is.

Additional context
N/A

@dxtrous dxtrous added bug Something isn't working enhancement New feature or request labels Mar 29, 2024
@dxtrous dxtrous added priority:low Triaged: low priority issue and removed bug Something isn't working labels Mar 29, 2024
@dxtrous dxtrous changed the title Code clean-up: string template elements repeated across code locations Code clean-up: prompt template string elements repeated across code locations Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Triaged: low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants