Merge pull request #462 from patchlevel/sync-projectionist-throw-by-e…

…rror add throw by error flag in sync projectionist wrapper
patchlevel · Jan 10, 2024 · 65b5875 · 65b5875
2 parents b60f718 + 05ede53
commit 65b5875
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/Projection/Projectionist/DefaultProjectionist.php b/src/Projection/Projectionist/DefaultProjectionist.php
@@ -94,17 +94,17 @@ public function boot(
                     $e->getMessage(),
                 ));
 
+                $projection->error(ProjectionError::fromThrowable($e));
+                $projection->disallowRetry();
+                $this->projectionStore->save($projection);
+
                 if ($throwByError) {
                     throw new ProjectionistError(
                         $projector::class,
                         $projection->id(),
                         $e,
                     );
                 }
-
-                $projection->error(ProjectionError::fromThrowable($e));
-                $projection->disallowRetry();
-                $this->projectionStore->save($projection);
             }
         }
 
@@ -469,6 +469,10 @@ private function handleMessage(Message $message, Projection $projection, bool $t
                 ),
             );
 
+            $projection->error(ProjectionError::fromThrowable($e));
+            $projection->incrementRetry();
+            $this->projectionStore->save($projection);
+
             if ($throwByError) {
                 throw new ProjectionistError(
                     $projector::class,
@@ -477,10 +481,6 @@ private function handleMessage(Message $message, Projection $projection, bool $t
                 );
             }
 
-            $projection->error(ProjectionError::fromThrowable($e));
-            $projection->incrementRetry();
-            $this->projectionStore->save($projection);
-
             return;
         }
 

diff --git a/src/Projection/Projectionist/SyncProjectionistEventBusWrapper.php b/src/Projection/Projectionist/SyncProjectionistEventBusWrapper.php
@@ -15,6 +15,7 @@ public function __construct(
         private readonly EventBus $parentEventBus,
         private readonly Projectionist $projectionist,
         private readonly LockFactory $lockFactory,
+        private readonly bool $throwByError = true,
     ) {
     }
 
@@ -29,7 +30,7 @@ public function dispatch(Message ...$messages): void
         }
 
         try {
-            $this->projectionist->run();
+            $this->projectionist->run(throwByError: $this->throwByError);
         } finally {
             $lock->release();
         }