Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI exit code always zero #6

Open
DHandspikerWade opened this issue Oct 19, 2016 · 3 comments
Open

CLI exit code always zero #6

DHandspikerWade opened this issue Oct 19, 2016 · 3 comments
Assignees
Labels

Comments

@DHandspikerWade
Copy link

DHandspikerWade commented Oct 19, 2016

I am using this project in my build pipeline for a couple of Chrome extensions. Normally this works fine but when it fails the CLI commands still return an exit code of zero.

Would it be possible to return an error code indicating that the command failed? It would increase the usability for people who use the module for scripting.

@pastak
Copy link
Owner

pastak commented Oct 26, 2016

👍

@pastak pastak added the bug label Oct 26, 2016
@pastak pastak self-assigned this Oct 26, 2016
@pastak
Copy link
Owner

pastak commented Oct 26, 2016

It solves fa7b212 . So please update to v0.4.1 and try it. Thanks

@pastak pastak closed this as completed Oct 26, 2016
@DHandspikerWade
Copy link
Author

It still uses exit code 0 when the API returns an error such as "Invalid Credentials". It appears to be any of the 4xx error codes.

@pastak pastak reopened this Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants