Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot testing for AST pretty printing #474

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 9, 2024

Adds snapshot testing of AST pretty printing tests

Partially addresses #473


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr force-pushed the feat-ast-snapshot-test branch from 613d839 to dd28ef5 Compare July 9, 2024 19:49
@jpschorr jpschorr requested a review from am357 July 9, 2024 19:49
Copy link

github-actions bot commented Jul 9, 2024

Conformance comparison report

Base (a54868e) 8ed3b97 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (a54868e) but now fail: 0

Number failing in Base (a54868e) but now pass: 0

@jpschorr jpschorr force-pushed the feat-ast-snapshot-test branch from dd28ef5 to 0d73952 Compare July 9, 2024 19:56
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.18%. Comparing base (a54868e) to head (0d73952).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files          67       67           
  Lines       18563    18563           
  Branches    18563    18563           
=======================================
  Hits        15070    15070           
  Misses       3051     3051           
  Partials      442      442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jpschorr jpschorr linked an issue Jul 9, 2024 that may be closed by this pull request
5 tasks
@jpschorr jpschorr merged commit 684fff3 into main Jul 9, 2024
19 checks passed
@jpschorr jpschorr deleted the feat-ast-snapshot-test branch July 9, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST Pretty-printer improvements and testing
2 participants