From b82ac8c77355be59874a57383f64813fb6b8efc8 Mon Sep 17 00:00:00 2001
From: John Ed Quinn <johqunn@amazon.com>
Date: Mon, 20 May 2024 11:14:40 -0700
Subject: [PATCH] Per PR feedback, removes NULL/MISSING from
 StaticType.ALL_TYPES

---
 .../partiql/lang/ast/passes/inference/StaticTypeCastTests.kt  | 2 ++
 .../visitors/inferencer/InferencerMultipleProblemsTests.kt    | 2 ++
 .../eval/visitors/inferencer/InferencerNaryArithmeticTests.kt | 2 ++
 .../eval/visitors/inferencer/InferencerNaryBetweenTests.kt    | 2 ++
 .../inferencer/InferencerNaryComparisonAndEqualityTests.kt    | 2 ++
 .../eval/visitors/inferencer/InferencerNaryConcatTests.kt     | 2 ++
 .../lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt  | 2 ++
 .../eval/visitors/inferencer/InferencerNaryLogicalTests.kt    | 2 ++
 .../lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt  | 2 ++
 .../eval/visitors/inferencer/InferencerTrimFunctionTests.kt   | 2 ++
 .../visitors/inferencer/InferencerUnaryArithmeticOpTests.kt   | 2 ++
 partiql-types/src/main/kotlin/org/partiql/types/StaticType.kt | 4 ----
 12 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/ast/passes/inference/StaticTypeCastTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/ast/passes/inference/StaticTypeCastTests.kt
index a21eef7a44..05056cb742 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/ast/passes/inference/StaticTypeCastTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/ast/passes/inference/StaticTypeCastTests.kt
@@ -3,6 +3,7 @@ package org.partiql.lang.ast.passes.inference
 import junitparams.JUnitParamsRunner
 import junitparams.Parameters
 import org.junit.Assert.assertEquals
+import org.junit.Ignore
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.partiql.types.DecimalType
@@ -85,6 +86,7 @@ class StaticTypeCastTests {
 
     @Test
     @Parameters
+    @Ignore("StaticType.ALL_TYPES no longer supports NULL/MISSING") // @Test comes from JUnit4, and therefore we must use @Ignore.
     fun unionTypeCastTests(tc: TestCase) = runTest(tc)
 
     @Test
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerMultipleProblemsTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerMultipleProblemsTests.kt
index d575d29830..8bbb41a2a9 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerMultipleProblemsTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerMultipleProblemsTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -20,6 +21,7 @@ import org.partiql.types.StructType
 
 class InferencerMultipleProblemsTests {
     @ParameterizedTest
+    @Disabled
     @MethodSource("parametersForMultipleInferenceProblemsTests")
     fun multipleInferenceProblemsTests(tc: TestCase) = runTest(tc)
 
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryArithmeticTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryArithmeticTests.kt
index d98031af4b..02e66c061d 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryArithmeticTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryArithmeticTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -29,6 +30,7 @@ class InferencerNaryArithmeticTests {
 
     @ParameterizedTest
     @MethodSource("parametersForNAryArithmeticTests")
+    @Disabled
     fun naryArithmeticInferenceTests(tc: InferencerTestUtil.TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryBetweenTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryBetweenTests.kt
index b11b853e6c..a57184c9bd 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryBetweenTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryBetweenTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -26,6 +27,7 @@ import org.partiql.types.StaticType
 class InferencerNaryBetweenTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryBetweenTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryBetweenInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryComparisonAndEqualityTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryComparisonAndEqualityTests.kt
index 1b38c53ff6..c2f2f2bf11 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryComparisonAndEqualityTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryComparisonAndEqualityTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -33,6 +34,7 @@ import org.partiql.types.StructType
 class InferencerNaryComparisonAndEqualityTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryComparisonAndEqualityTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryComparisonAndEqualityInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryConcatTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryConcatTests.kt
index 35d364ba82..b7c20bf6f4 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryConcatTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryConcatTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -25,6 +26,7 @@ import org.partiql.types.StringType
 class InferencerNaryConcatTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryConcatTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryConcatInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt
index 7114ac031d..3da73fd972 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -22,6 +23,7 @@ class InferencerNaryLikeTests {
 
     @ParameterizedTest
     @MethodSource("parametersForNAryLikeTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryLikeInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLogicalTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLogicalTests.kt
index 3211057dd3..5c29463325 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLogicalTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLogicalTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -25,6 +26,7 @@ import org.partiql.types.StaticType
 class InferencerNaryLogicalTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryLogicalTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryLogicalInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt
index 14aa60fa93..1ed1b5c31a 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -31,6 +32,7 @@ import org.partiql.types.StaticType
 class InferencerNaryOpInTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryOpInTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun nAryOpInTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerTrimFunctionTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerTrimFunctionTests.kt
index 94e9d5f420..24df6f7e59 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerTrimFunctionTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerTrimFunctionTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.lang.eval.visitors.inferencer.InferencerTestUtil.TestCase
@@ -10,6 +11,7 @@ import org.partiql.types.StaticType
 class InferencerTrimFunctionTests {
     @ParameterizedTest
     @MethodSource("parametersForTrimFunctionTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun trimFunctionTests(tc: TestCase) = runTest(tc)
 
     companion object {
diff --git a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerUnaryArithmeticOpTests.kt b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerUnaryArithmeticOpTests.kt
index fdcca5ee45..140dfe07c0 100644
--- a/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerUnaryArithmeticOpTests.kt
+++ b/partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerUnaryArithmeticOpTests.kt
@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -15,6 +16,7 @@ import org.partiql.types.StaticType
 class InferencerUnaryArithmeticOpTests {
     @ParameterizedTest
     @MethodSource("parametersForUnaryArithmeticOpTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun unaryArithmeticInferenceTests(tc: InferencerTestUtil.TestCase) = InferencerTestUtil.runTest(tc)
 
     companion object {
diff --git a/partiql-types/src/main/kotlin/org/partiql/types/StaticType.kt b/partiql-types/src/main/kotlin/org/partiql/types/StaticType.kt
index 15804766ef..b012d5ceef 100644
--- a/partiql-types/src/main/kotlin/org/partiql/types/StaticType.kt
+++ b/partiql-types/src/main/kotlin/org/partiql/types/StaticType.kt
@@ -115,10 +115,6 @@ public sealed class StaticType {
         @OptIn(PartiQLTimestampExperimental::class)
         @JvmStatic
         public val ALL_TYPES: List<SingleType> = listOf(
-            @Suppress("DEPRECATION")
-            MISSING,
-            @Suppress("DEPRECATION")
-            NULL,
             BOOL,
             INT2,
             INT4,