[tracking] Migrate pallets to umbrella crate

[re-gius]

Migrate all pallets to polkadot-sdk-frame by adding types and preludes to it when necessary. As a reference, you can look into #5995.

The guidelines of the umbrella crate are as follows:

polkadot-sdk/substrate/frame/src/lib.rs

Lines 134 to 150 in 06a68be

	//! ## Maintenance Note
	//!
	//! > Notes for the maintainers of this crate, describing how the re-exports and preludes should
	//! > work.
	//!
	//! * Preludes should be extensive. The goal of this pallet is to be ONLY used with the preludes.
	//! The domain-specific modules are just a backup, aiming to keep things organized. Don't hesitate
	//! in adding more items to the main prelude.
	//! * The only non-module, non-prelude items exported from the top level crate is the `pallet`
	//! macro, such that we can have the `#[frame::pallet] mod pallet { .. }` syntax working.
	//! * In most cases, you might want to create a domain-specific module, but also add it to the
	//! preludes, such as `hashing`.
	//! * The only items that should NOT be in preludes are those that have been placed in
	//! `frame-support`/`sp-runtime`, but in truth are related to just one pallet.
	//! * The currency related traits are kept out of the preludes to encourage a deliberate choice of
	//! one over the other.
	//! * `runtime::apis` should expose all common runtime APIs that all FRAME-based runtimes need.

✅ Checklist:

• Add polkadot-sdk-frame to the Cargo.toml
• Remove all imports from frame_support, sp_runtime and similar, and replace with the appropriate prelude::*
• For items that are now not in scope, use the above guideline to decide if you should add them to prelude, or reside to using deps
• Update Cargo.toml to remove all unneeded dependencies.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on (here or in the comments below). Please pick only one or a small set of pallets - not all at once. This keeps review times low. Add a comment below to announce the pallets you're working on.

Completed:

• pallet-multisig Use frame umbrella crate in pallet-proxy and pallet-multisig #5995
• pallet-proxy Use frame umbrella crate in pallet-proxy and pallet-multisig #5995

In progress:

• pallet-babe Use frame umbrella crate in pallet-babe & pallet-staking-reward-curve #6412
• pallet-staking-reward-curve Use frame umbrella crate in pallet-babe & pallet-staking-reward-curve #6412

To do:

• all the other pallets.

[bennethxyz]

Can I pick this up @re-gius

Thinking this should be a tracking issue as it involves more than one crate but happy to do it!

[re-gius]

Can I pick this up @re-gius

Thinking this should be a tracking issue as it involves more than one crate but happy to do it!

Yes, it's going to be a tracking issue. You are more than welcome to start working at some pallets/crates, ideally one or two per PR.

[Krayt78]

Are there still some pallets to work on or are you doing all of them?

[sylvaincormier]

I am not fast enough, will try another issue.

[runcomet]

Some updates:

• pallet-alliance Migrate pallet-alliance to umbrella crate #6541
• pallet-asset-conversion Migrate pallet-asset-conversion to umbrella crate #6548
• pallet-asset-rate Migrate pallet-asset-rate to umbrella crate #6580
• pallet-assets Migrate pallet-assets to umbrella crate #6590
• pallet-assets-freezer Migrate pallet-assets-freezer to umbrella crate #6599
• pallet-atomic-swap Migrate pallet-atomic-swap to umbrella crate #6601
• pallet-aura Migrate pallet-aura to umbrella crate #6622
• pallet-authority-discovery Migrate pallet-authority-discovery to umbrella crate  #6619
• pallet-authorship Migrate pallet-authorship to umbrella crate #6620

[bennethxyz]

PRs for this Issue:

• pallet-timestamp Migrate pallet-timestamp to umbrella crate #6523
• pallet-tips Migrate pallet-tips to umbrella crate #6532
• pallet-(asset-conversion-tx-payment, asset-tx-payment, skip-feeless-payment, transaction-payment) Migrate pallet-transaction-payment to umbrella crate #6625
• pallet-transaction-storage Migrate pallet-transaction-storage to umbrella crate. #6627
• pallet-treasury Migrate pallet-treasury to umbrella crate #6629
• pallet-tx-pause Migrate pallet-tx-pause to umbrella crate #6630
• pallet-uniques Migrate pallet-uniques to umbrella crate #6511
• pallet-utility Migrate pallet-utility to umbrella crate  #6512
• pallet-verify-signature Migrate pallet-verify-signature to umbrella crate #6515
• pallet-vesting Migrate pallet-vesting to umbrella crate #6513
• pallet-whitelist Migrate pallet-whitelist to umbrella crate #6514

[kianenigma]

bennethxyz runcomet can you please read the new checklist that I put above, and make sure it is clear? Feel to ask more questions from me and @re-gius. Once clear, please update the PRs (most of them are not 100% correct).