Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substrate-wasm-builder bug in backport update to 1.1.0 #4953

Closed
2 tasks done
alexxxkny opened this issue Jul 5, 2024 · 1 comment
Closed
2 tasks done

substrate-wasm-builder bug in backport update to 1.1.0 #4953

alexxxkny opened this issue Jul 5, 2024 · 1 comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@alexxxkny
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

I started getting compact wasm as WASM_BINARY instead of compact.compressed one. I believe that the reason is this backport update #4585. compact_wasm_file function returns (wasm_compact_path, wasm_compact_compressed_path) here. But parent function receive this as (compressed, compact_blob_path) here. Therefore compressed and compact paths are switched.

If you also depend on release-polkadot-v1.1.0 branch and are experiencing the same you can set substrate-wasm-builder to v12.0.0 from crates.io like this substrate-wasm-builder = { version = "12.0.0" }

Steps to reproduce

No response

@alexxxkny alexxxkny added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Jul 5, 2024
@bkchr
Copy link
Member

bkchr commented Jul 5, 2024

Ty for raising this @alexxxkny! I pushed a commit to the branch that fixes this!

@bkchr bkchr closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

No branches or pull requests

2 participants