Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/ui: Enhance regex filtering in SimpleMatchers component #5288

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Nov 11, 2024

This fixes the following comments:

  • When clicking on a value in the dropdown I expect the selected value to be set as the value in the input of the dropdown. Further on, this is going to be helpful as I only need to adjust some parts of the values for the regex from prometheus-k8s-0 to prometheus-k8s-\d rather than still having to type the entire thing.

  • Something about the Add button still seems weird. It's still floating above the input text. (24s in the video). Can we have two vertical divs? One with the input and one below with the button? Then it'll always be below and never next or above the input.

@yomete yomete requested a review from a team as a code owner November 11, 2024 11:59
Copy link

alwaysmeticulous bot commented Nov 11, 2024

✅ Meticulous spotted zero visual differences across 334 screens tested: view results.

Meticulous simulated ~4 hours of user flows against this PR.

Expected differences? Click here. Last updated for commit e5fcea9. This comment will update as new commits are pushed.

Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very nice!
That is exactly what I imagined. 🥳
Love the detail that the copy into the input field only works on regex selectors. 💯
Ship it! 🎉

@yomete
Copy link
Contributor Author

yomete commented Nov 12, 2024

Very, very nice! That is exactly what I imagined. 🥳 Love the detail that the copy into the input field only works on regex selectors. 💯 Ship it! 🎉

awesome!

@yomete yomete merged commit 1586ba0 into main Nov 12, 2024
38 checks passed
@yomete yomete deleted the simple-matchers-regex-filtering branch November 12, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants