Fix Robonomics & Bifrost transfer

paraspell · Dec 6, 2023 · aba856f · aba856f
1 parent e1fe819
commit aba856f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/src/nodes/PolkadotXCMTransferImpl.ts b/src/nodes/PolkadotXCMTransferImpl.ts
@@ -13,7 +13,7 @@ class PolkadotXCMTransferImpl {
       serializedApiCallEnabled
     }: PolkadotXCMTransferInput,
     method: string,
-    fees: 'Unlimited' | undefined = undefined
+    fees: 'Unlimited' | { Limited: string } | undefined = undefined
   ): Extrinsic | TSerializedApiCall {
     if (serializedApiCallEnabled === true) {
       return {

diff --git a/src/nodes/supported/BifrostKusama.ts b/src/nodes/supported/BifrostKusama.ts
@@ -17,7 +17,8 @@ class BifrostKusama extends ParachainNode implements IXTokensTransfer {
 
   transferXTokens(input: XTokensTransferInput): Extrinsic | TSerializedApiCall {
     // Multiple asset options need addressing
-    return XTokensTransferImpl.transferXTokens(input, { Token: input.currency })
+    const currencySelection = { Native: input.currency }
+    return XTokensTransferImpl.transferXTokens(input, currencySelection)
   }
 }
 

diff --git a/src/nodes/supported/BifrostPolkadot.ts b/src/nodes/supported/BifrostPolkadot.ts
@@ -17,7 +17,7 @@ export class BifrostPolkadot extends ParachainNode implements IXTokensTransfer {
 
   transferXTokens(input: XTokensTransferInput): Extrinsic | TSerializedApiCall {
     // Multiple asset options need addressing
-    const currencySelection = { Token: input.currency }
+    const currencySelection = { Native: input.currency }
     return XTokensTransferImpl.transferXTokens(input, currencySelection)
   }
 }
diff --git a/src/nodes/supported/Robonomics.ts b/src/nodes/supported/Robonomics.ts
@@ -15,12 +15,15 @@ class Robonomics extends ParachainNode implements IPolkadotXCMTransfer {
     super('Robonomics', 'robonomics', 'kusama', Version.V1)
   }
 
+  private static readonly FEE = '400000000'
+
   transferPolkadotXCM(input: PolkadotXCMTransferInput): Extrinsic | TSerializedApiCall {
-    // TESTED https://robonomics.subscan.io/xcm_message/kusama-e9641113dae59920e5cc0e012f1510ea0e2d0455
-    // TESTED https://robonomics.subscan.io/xcm_message/kusama-20b03208c99f2ef29d2d4b4cd4bc5659e54311ea
-    const method =
-      input.scenario === 'ParaToPara' ? 'reserveTransferAssets' : 'reserveWithdrawAssets'
-    return PolkadotXCMTransferImpl.transferPolkadotXCM(input, method)
+    if (input.scenario === 'ParaToPara') {
+      return PolkadotXCMTransferImpl.transferPolkadotXCM(input, 'limitedReserveTransferAssets', {
+        Limited: Robonomics.FEE
+      })
+    }
+    return PolkadotXCMTransferImpl.transferPolkadotXCM(input, 'reserveWithdrawAssets')
   }
 }