Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new component: Settings dialog #621

Closed
3 tasks
Sebastian-ubs opened this issue Nov 3, 2023 · 2 comments
Closed
3 tasks

Create new component: Settings dialog #621

Sebastian-ubs opened this issue Nov 3, 2023 · 2 comments
Labels
extensions team Able to be worked on by extensions team internal Internal issue that doesn't directly affect extension developers or users

Comments

@Sebastian-ubs
Copy link
Contributor

Sebastian-ubs commented Nov 3, 2023

User Story
As a user, I want all settings to be presented in a similar way

Description
Create a common papi component for

This component should use the following components

  • Dialog Dev Design Modality #470
  • Vertical tab navigator Create new papi component: Vertical tab navigator  #620
  • Settings list - a new sub component to be created, that represents a single list of settings (e.g. of one category inside of a tab navigator tab).
    • is that the same thing mentioned twice in # 503 and # 510 as "Provide components for settings created"?
    • Compare
      <List>
      {fetchSettings(group).map((settingKey) => (
      <span key={group.properties[settingKey].label} className="settings-list-item">
      <ListItem divider key={settingKey}>
      <ListItemText
      primary={group.properties[settingKey].label}
      secondary={group.properties[settingKey].description}
      />
      {components[settingKey] ? (
      createElement(components[settingKey], {
      setting: settingValues[settingKey],
      setSetting: (value: unknown) => setSettingValue(settingKey, value),
      })
      ) : (
      <Typography component="span" alignSelf="center" variant="caption">
      Setting Action Missing
      </Typography>
      )}
      </ListItem>
      </span>
      ))}
      </List>

Mockups dev link

Dialog Vertical tab navigator Settings list
Screenshot 2023-11-03 145903 grafik grafik
@Sebastian-ubs Sebastian-ubs added extensions team Able to be worked on by extensions team internal Internal issue that doesn't directly affect extension developers or users labels Nov 3, 2023
@Sebastian-ubs Sebastian-ubs changed the title Create new papi component: Settings dialog Create new component: Settings dialog Nov 3, 2023
@tjcouch-sil
Copy link
Member

@Sebastian-ubs can this be closed? I believe this was done with #867

@tjcouch-sil tjcouch-sil moved this to 📥 For Consideration in Paranext Oct 24, 2024
@Sebastian-ubs
Copy link
Contributor Author

what's described in here is basically done. the story for the new design to come is

@github-project-automation github-project-automation bot moved this from 📥 For Consideration to ✅ Done in Paranext Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions team Able to be worked on by extensions team internal Internal issue that doesn't directly affect extension developers or users
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants