Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks: Create Run Basic Checks dialog #447

Closed
katherinejensen00 opened this issue Sep 26, 2023 · 4 comments · Fixed by #897
Closed

Checks: Create Run Basic Checks dialog #447

katherinejensen00 opened this issue Sep 26, 2023 · 4 comments · Fixed by #897
Assignees
Labels
extensions team Able to be worked on by extensions team

Comments

@katherinejensen00
Copy link
Contributor

katherinejensen00 commented Sep 26, 2023

As a user, I want to find and run the checks I care about quickly so that I can efficiently see relevant information about what I need to fix about my text.

Design the structure for the run basic checks dialog (note there is a separate case for designing the anatomy of a check).
One thing to consider is how to dynamically find and display checks

Assume we will recreate something similar to what was done in PT9 unless UX has a different design in place.

From PT9:

Image

@katherinejensen00 katherinejensen00 added this to the Checks milestone Sep 26, 2023
@katherinejensen00 katherinejensen00 moved this to Open in Paranext Sep 26, 2023
@lyonsil lyonsil removed this from the Checks milestone Sep 29, 2023
@Sebastian-ubs
Copy link
Contributor

make basic checks a dialog with non scrolling footer buttons.

@Sebastian-ubs
Copy link
Contributor

Sebastian-ubs commented Nov 2, 2023

follow up of

related to

@lyonsil lyonsil changed the title Dev design Run Basic Checks Dialog Create Run Basic Checks dialog Apr 29, 2024
@lyonsil lyonsil added the extensions team Able to be worked on by extensions team label Apr 29, 2024
@lyonsil lyonsil moved this from 📥 On Deck to 🎬 Product Backlog in Paranext Apr 30, 2024
@lyonsil lyonsil changed the title Create Run Basic Checks dialog Checks: Create Run Basic Checks dialog Apr 30, 2024
@katherinejensen00 katherinejensen00 moved this from 🎬 Product Backlog to 🔖 ToDo in Paranext May 1, 2024
@jolierabideau jolierabideau self-assigned this May 3, 2024
@jolierabideau jolierabideau moved this from 🔖 ToDo to 🏗 In progress in Paranext May 3, 2024
@jolierabideau
Copy link
Contributor

@roopa0222

To be tested from an extension:

  • New Checklist component in platform-bible-react
  • ChapterRangeSelector, no longer accepts startChapter and endChapter as props

@jolierabideau jolierabideau linked a pull request May 22, 2024 that will close this issue
@jolierabideau jolierabideau moved this from 🏗 In progress to 👀 In review in Paranext May 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext May 24, 2024
@roopa0222
Copy link

  1. Updated the ChapterRangeSelector component in my test extension.
  2. Used Checklist Component in my test extension. Tested all the component props and functions. Everything working as expected.

In my UI

  <Checklist
          id="checkListTestId"
          className="papi-checkbox"
          legend="Country"
          listItems={countryList}
          selectedListItems={selectCountry}
          createLabel={OnCreateLabel}
          handleSelectListItem={OnHandleSelectListItem}
        />

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions team Able to be worked on by extensions team
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants