From 9ba9f351d74e9951c65e572002c64115dcb50ba5 Mon Sep 17 00:00:00 2001 From: Jolie Rabideau Date: Tue, 26 Mar 2024 17:26:15 -0400 Subject: [PATCH] revert some unnecessary changes --- lib/papi-dts/papi.d.ts | 3 +-- src/declarations/papi-shared-types.ts | 3 +-- src/main/data/core-project-settings-info.data.ts | 4 +++- src/main/services/project-settings.service-host.ts | 3 +-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/papi-dts/papi.d.ts b/lib/papi-dts/papi.d.ts index 9974826036..8ac582d69b 100644 --- a/lib/papi-dts/papi.d.ts +++ b/lib/papi-dts/papi.d.ts @@ -2486,8 +2486,7 @@ declare module 'papi-shared-types' { > = { /** * Set the value of the specified project setting on this project. `setSetting` must call - * `papi.projectSettings.isValid(newValue, currentValue, key, allChanges, projectType)` before - * allowing the setting change. + * `papi.projectSettings.isValid` before allowing the setting change. * * @param key The string id of the project setting to change * @param newSetting The value that is to be set to the project setting. diff --git a/src/declarations/papi-shared-types.ts b/src/declarations/papi-shared-types.ts index a4b0cf8421..fad7b5e050 100644 --- a/src/declarations/papi-shared-types.ts +++ b/src/declarations/papi-shared-types.ts @@ -173,8 +173,7 @@ declare module 'papi-shared-types' { > = { /** * Set the value of the specified project setting on this project. `setSetting` must call - * `papi.projectSettings.isValid(newValue, currentValue, key, allChanges, projectType)` before - * allowing the setting change. + * `papi.projectSettings.isValid` before allowing the setting change. * * @param key The string id of the project setting to change * @param newSetting The value that is to be set to the project setting. diff --git a/src/main/data/core-project-settings-info.data.ts b/src/main/data/core-project-settings-info.data.ts index bee8462344..f2fac0e858 100644 --- a/src/main/data/core-project-settings-info.data.ts +++ b/src/main/data/core-project-settings-info.data.ts @@ -19,7 +19,7 @@ export type AllProjectSettingsInfo = { }; /** Info about all project settings built into core. Does not contain info for extensions' settings */ -export const coreProjectSettingsInfo: Partial = { +const coreProjectSettingsInfo: Partial = { 'platform.fullName': { default: '%project_full_name_missing%' }, 'platform.language': { default: '%project_language_missing%' }, 'platformScripture.booksPresent': { @@ -54,3 +54,5 @@ export const coreProjectSettingsValidators: Partial