From 5075672f679348e8b96452f2d445071c97115b59 Mon Sep 17 00:00:00 2001 From: Ira Hopkinson Date: Tue, 27 Aug 2024 13:40:52 +1200 Subject: [PATCH] - code review --- lib/papi-dts/package.json | 3 ++- lib/papi-dts/tsconfig.lint.json | 10 ++++++++-- lib/platform-bible-react/package.json | 2 +- lib/platform-bible-utils/package.json | 2 +- package.json | 3 ++- tsconfig.json | 3 ++- 6 files changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/papi-dts/package.json b/lib/papi-dts/package.json index 52782edc1a..b97e939d07 100644 --- a/lib/papi-dts/package.json +++ b/lib/papi-dts/package.json @@ -32,7 +32,8 @@ "clean": "rimraf papi.tsbuildinfo", "lint": "cross-env NODE_ENV=development eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .", "lint-fix": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint", - "lint:staged": "lint-staged -q" + "lint:staged": "lint-staged -q", + "typecheck": "tsc -p ./tsconfig.lint.json" }, "lint-staged": { "*.{cjs,js,jsx,ts,tsx}": ["prettier --write", "cross-env NODE_ENV=development eslint --cache"], diff --git a/lib/papi-dts/tsconfig.lint.json b/lib/papi-dts/tsconfig.lint.json index 0d9138dbbf..ddf86de666 100644 --- a/lib/papi-dts/tsconfig.lint.json +++ b/lib/papi-dts/tsconfig.lint.json @@ -1,4 +1,10 @@ { - "extends": "./tsconfig", - "files": [".eslintrc.cjs", "edit-papi-d-ts.ts", "papi.d.ts"] + "extends": "../../tsconfig", + "compilerOptions": { + "module": "ESNext", + "baseUrl": "./", + "noEmit": true + }, + "include": [".eslintrc.cjs", "edit-papi-d-ts.ts", "papi.d.ts"], + "exclude": [] } diff --git a/lib/platform-bible-react/package.json b/lib/platform-bible-react/package.json index a8f988bf6d..e5220fa37d 100644 --- a/lib/platform-bible-react/package.json +++ b/lib/platform-bible-react/package.json @@ -2,7 +2,7 @@ "name": "platform-bible-react", "version": "0.0.1", "type": "module", - "description": "React components and hooks to use in Platform - packaged to include styles sheets.", + "description": "React components and hooks to use in Paranext - packaged to include styles sheets.", "license": "MIT", "homepage": "https://github.com/paranext/paranext-core/tree/main/lib/platform-bible-react", "bugs": { diff --git a/lib/platform-bible-utils/package.json b/lib/platform-bible-utils/package.json index 1a96b7c699..84145dfe13 100644 --- a/lib/platform-bible-utils/package.json +++ b/lib/platform-bible-utils/package.json @@ -2,7 +2,7 @@ "name": "platform-bible-utils", "version": "0.0.1", "type": "module", - "description": "Utilities to use in Platform.", + "description": "Utilities to use in Paranext.", "license": "MIT", "homepage": "https://github.com/paranext/paranext-core/tree/main/lib/platform-bible-utils", "bugs": { diff --git a/package.json b/package.json index e8ad886475..a304d420ec 100644 --- a/package.json +++ b/package.json @@ -87,9 +87,10 @@ "storybook:build": "storybook build", "test": "npm run test:core && npm run test --workspaces --if-present", "test:core": "jest --silent", - "typecheck": "npm run typecheck:core && npm run typecheck:extensions && npm run typecheck:platform-bible-utils && npm run typecheck:platform-bible-react", + "typecheck": "npm run typecheck:core && npm run typecheck:extensions && npm run typecheck:papi-dts && npm run typecheck:platform-bible-utils && npm run typecheck:platform-bible-react", "typecheck:core": "tsc -p ./tsconfig.lint.json", "typecheck:extensions": "cd extensions && npm run typecheck", + "typecheck:papi-dts": "cd lib/papi-dts && npm run typecheck", "typecheck:platform-bible-react": "cd lib/platform-bible-react && npm run typecheck", "typecheck:platform-bible-utils": "cd lib/platform-bible-utils && npm run typecheck" }, diff --git a/tsconfig.json b/tsconfig.json index a33f7d9407..663f916396 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -47,7 +47,8 @@ ".erb/dll", "extensions", "lib/platform-bible-react", - "lib/platform-bible-utils" + "lib/platform-bible-utils", + "lib/papi-dts" ], "ts-node": { "require": ["tsconfig-paths/register"]