chore: move serde bincode compat bound to NodePrimitives #13393
Merged
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
Rjected,
joshieDo,
emhane,
mattsse and
rakita
as code owners
mattsse
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
BlockBody: SerdeBincodeCompatbound toFullBlockBodyand enforcesFull*bounds directly onNodePrimitives. This is needed to allow usingreth_primitives::BlockBodyby just bounding transaction withT: SignedTransactionWe can't make bincode compat a supertrait of
SignedTransactionbecause we need it to be implemented in pooled transaction as well which is never being bincode serializedThis essentially makes
NodePrimitivessame asFullNodePrimitiveswhich makes sense imo because there's not much benefit in implementing NodePrimitives for a set of types which can't be used for all of the components