Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(engine): include spent calculation time in StateRootTask output #13387

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

fgimenez
Copy link
Member

Allows to obtain the time spent in state root calculation, given that the state updates are streamed from the executor, we can't know when the computation starts from the code that spawns the task and calls the executor.

@fgimenez fgimenez requested a review from shekhirin December 13, 2024 16:35
@fgimenez fgimenez added C-perf A change motivated by improving speed, memory usage or disk footprint A-blockchain-tree Related to sidechains, reorgs and pending blocks A-trie Related to Merkle Patricia Trie implementation labels Dec 13, 2024
@fgimenez fgimenez added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit ca4095a Dec 13, 2024
43 checks passed
@fgimenez fgimenez deleted the fgimenez/srt-timing branch December 13, 2024 18:21
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants