chore(sdk): Add adapter type for NodePrimitives::Receipt
#12674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Nov 19, 2024
crates/primitives-traits/src/node.rs
Outdated
| @@ -73,3 +73,6 @@ where | |||
| type TxType = T::TxType; | |||
| type Receipt = T::Receipt; | |||
| } | |||
|
|
|||
| /// Helper adapter type for accessing [`NodePrimitives`] receipt type. | |||
| pub type Rcpt<N> = <N as NodePrimitives>::Receipt; | |||
There was a problem hiding this comment.
not a fan of abbreviations for aliases.
we will likely need a few more, so I think we should come up with a common prefix for these, perhaps just NodeReceipt?
There was a problem hiding this comment.
I thought we rename it when we don't use reth_primitives::Receipt in the code base anymore?
There was a problem hiding this comment.
ah no the trait is the problem nvm...wanted smthg short...
There was a problem hiding this comment.
ReceiptTy? common suffix?
mattsse
approved these changes
Nov 19, 2024
| @@ -73,3 +73,6 @@ where | |||
| type TxType = T::TxType; | |||
| type Receipt = T::Receipt; | |||
| } | |||
|
|
|||
| /// Helper adapter type for accessing [`NodePrimitives`] receipt type. | |||
| pub type ReceiptTy<N> = <N as NodePrimitives>::Receipt; | |||
There was a problem hiding this comment.
I can live with a common suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12454