Introduce StateCommitment in StateProviders #12602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
requested review from
joshieDo,
rkrasiuk,
rakita,
shekhirin and
onbjerg
as code owners
klkvr
reviewed
Nov 19, 2024
| @@ -41,13 +41,15 @@ use std::fmt::Debug; | |||
| /// - [`tables::AccountChangeSets`] | |||
| /// - [`tables::StorageChangeSets`] | |||
| #[derive(Debug)] | |||
| pub struct HistoricalStateProviderRef<'b, Provider> { | |||
| pub struct HistoricalStateProviderRef<'b, Provider, SC> { | |||
There was a problem hiding this comment.
given that Provider we pass here already knows the StateCommitment type let's avoid introducing an additional generic here and instead just add a trait like
trait StateCommitmentProvider {
type StateCommitment: StateCommitment;
}which would be implemented by the DatabaseProvider.
That way we can just enforce this bound on historical providers
There was a problem hiding this comment.
Great suggestion! This should make things much cleaner. I will implement this pattern now.
frisitano
force-pushed
the
feat/provider-state-commitment
branch
from
f0f7fa1 to
52426db
Compare
klkvr
approved these changes
Nov 20, 2024
mattsse
approved these changes
Nov 26, 2024
|
really sorry about the slow progress, |
No problem I understand, thanks for keeping this in mind and pushing it forward 🙏 |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #11867