chore(sdk): Define MaybeSerde
#12577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
mattsse
reviewed
Nov 16, 2024
crates/primitives-traits/src/lib.rs
Outdated
|
|
||
| /// Helper trait that requires de-/serialize implementation since `serde` feature is enabled. | ||
| #[cfg(feature = "serde")] | ||
| pub trait MaybeSerialize: serde::Serialize + for<'de> serde::Deserialize<'de> {} |
There was a problem hiding this comment.
since this is ser + de perhaps we should rename this to MaybeSerde?
There was a problem hiding this comment.
this is the same on main, should be addressed in sep pr
emhane
changed the title
MaybeSerializeMaybeSerde
mattsse
force-pushed
the
emhane/maybe-serialize
branch
from
4a0cdad to
6814746
Compare
mattsse
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12575
interfaces nicely with alloy types for which serde serialisation is feature gated